From 841f96f3fd5a3ed39459fe9d4e31f8c9c94db59f Mon Sep 17 00:00:00 2001 From: Tom Boullay Date: Mon, 11 May 2026 13:14:08 +0200 Subject: [PATCH] update: doc --- docs/technical/editor.md | 2 +- docs/user/editor.md | 2 +- public/sounds/dialogue/subtitles/en/README.md | 11 +++++++++++ vite.config.ts | 4 +++- 4 files changed, 16 insertions(+), 3 deletions(-) create mode 100644 public/sounds/dialogue/subtitles/en/README.md diff --git a/docs/technical/editor.md b/docs/technical/editor.md index 572f2d2..0e6c9b1 100644 --- a/docs/technical/editor.md +++ b/docs/technical/editor.md @@ -178,7 +178,7 @@ The current model is one SRT file per voice and language. A dialogue entry refer SRT timecodes are relative to the dialogue audio file being previewed, not to the global game timeline. -Missing English SRT files are warnings because runtime loading falls back to French subtitles when the selected language is not available. +Missing English SRT files are warnings, not errors, because runtime loading falls back to French subtitles when the selected language is not available. Keep this behavior until the English translation workflow is ready. ## Dialogue Manifest Editing diff --git a/docs/user/editor.md b/docs/user/editor.md index 2dcf0be..af2dd5c 100644 --- a/docs/user/editor.md +++ b/docs/user/editor.md @@ -119,7 +119,7 @@ The validation checks: - French SRT files - subtitle cue indexes referenced by the manifest -Missing English SRT files are warnings because the runtime falls back to French subtitles. +Missing English SRT files are warnings, not errors, because the runtime falls back to French subtitles. This is intentional until the English translation workflow is ready. ## Editing Cinematics diff --git a/public/sounds/dialogue/subtitles/en/README.md b/public/sounds/dialogue/subtitles/en/README.md new file mode 100644 index 0000000..04648de --- /dev/null +++ b/public/sounds/dialogue/subtitles/en/README.md @@ -0,0 +1,11 @@ +# English Subtitle Fallback + +English SRT files are intentionally optional for now. + +The dialogue runtime first tries the selected subtitle language, then falls back to French. Missing English files should therefore remain validation warnings, not blocking errors, until the English translation workflow is ready. + +Expected future files: + +- `narrateur.srt` +- `fermier.srt` +- `electricienne.srt` diff --git a/vite.config.ts b/vite.config.ts index f623806..0be2836 100644 --- a/vite.config.ts +++ b/vite.config.ts @@ -361,7 +361,9 @@ async function validateDialogueAssets(): Promise { if (enSubtitlePath) { const resolvedEnPath = resolvePublicPath(enSubtitlePath); if (!resolvedEnPath || !fs.existsSync(resolvedEnPath)) { - warnings.push(`English subtitle file missing for voice ${voice.id}`); + warnings.push( + `English subtitle file missing for voice ${voice.id}; runtime will fall back to French`, + ); } } }