fix(repair-ebike): freeze repair transform and case-driven cooling swap

This commit is contained in:
Tom Boullay
2026-06-03 07:00:16 +02:00
parent 08c10acd48
commit a0482aa04b
4 changed files with 89 additions and 43 deletions
@@ -1,43 +1,32 @@
import { useState } from "react";
import { GrabbableObject } from "@/components/three/interaction/GrabbableObject"; import { GrabbableObject } from "@/components/three/interaction/GrabbableObject";
import { TriggerObject } from "@/components/three/interaction/TriggerObject";
import { RepairObjectModel } from "@/components/three/gameplay/RepairObjectModel"; import { RepairObjectModel } from "@/components/three/gameplay/RepairObjectModel";
import { REPAIR_INTERACTION_RADIUS } from "@/data/gameplay/repairGameConfig";
import type { Vector3Tuple } from "@/types/three/three"; import type { Vector3Tuple } from "@/types/three/three";
interface RepairEbikeRepairTriggerProps { interface RepairEbikeRepairTriggerProps {
anchor: Vector3Tuple; anchor: Vector3Tuple;
onRepair: () => void; installed: boolean;
} }
const REPLACEMENT_MODEL_PATH = "/models/refroidisseur/model.gltf"; const REPLACEMENT_MODEL_PATH = "/models/refroidisseur/model.gltf";
const TRIGGER_OFFSET: Vector3Tuple = [0, 0.9, 0];
/** /**
* Ebike-specific fake replacement flow: the broken radiator node is * Ebike-specific fake replacement flow: the broken radiator node is
* hidden in the shared ExplodableModel, a grabbable copy appears at the * hidden in the shared ExplodableModel, a grabbable copy appears at the
* same anchor, then pressing E respawns a fresh part with a halo before * same anchor, then RepairGame/RepairMissionCase controls the install
* the reassembly step starts. * interaction and this component swaps the copy for a fresh glowing part.
*/ */
export function RepairEbikeRepairTrigger({ export function RepairEbikeRepairTrigger({
anchor, anchor,
onRepair, installed,
}: RepairEbikeRepairTriggerProps): React.JSX.Element { }: RepairEbikeRepairTriggerProps): React.JSX.Element {
const [isInstalled, setIsInstalled] = useState(false);
function handleRepair(): void {
if (isInstalled) return;
setIsInstalled(true);
window.setTimeout(onRepair, 450);
}
return ( return (
<group> <group>
{!isInstalled ? ( {!installed ? (
<GrabbableObject <GrabbableObject
position={anchor} position={anchor}
colliders="ball" colliders="ball"
handControlled handControlled
lockUntilGrab
label="Retirer le refroidisseur" label="Retirer le refroidisseur"
> >
<RepairObjectModel <RepairObjectModel
@@ -63,23 +52,6 @@ export function RepairEbikeRepairTrigger({
</mesh> </mesh>
</group> </group>
)} )}
<TriggerObject
position={[
anchor[0] + TRIGGER_OFFSET[0],
anchor[1] + TRIGGER_OFFSET[1],
anchor[2] + TRIGGER_OFFSET[2],
]}
colliders="ball"
label="Changez le refroidisseur"
radius={REPAIR_INTERACTION_RADIUS}
onTrigger={handleRepair}
>
<mesh>
<sphereGeometry args={[0.55, 16, 16]} />
<meshBasicMaterial colorWrite={false} depthWrite={false} />
</mesh>
</TriggerObject>
</group> </group>
); );
} }
+71 -4
View File
@@ -58,6 +58,11 @@ interface RepairMissionAssetPreloaderProps {
config: RepairMissionConfig; config: RepairMissionConfig;
} }
interface EbikeRepairTransform {
position: Vector3Tuple;
rotationY: number;
}
function RepairMissionAssetPreloader({ function RepairMissionAssetPreloader({
config, config,
}: RepairMissionAssetPreloaderProps): null { }: RepairMissionAssetPreloaderProps): null {
@@ -107,6 +112,9 @@ export function RepairGame({
const [explodedParts, setExplodedParts] = useState<readonly ExplodedPart[]>( const [explodedParts, setExplodedParts] = useState<readonly ExplodedPart[]>(
[], [],
); );
const [ebikeRepairTransform, setEbikeRepairTransform] =
useState<EbikeRepairTransform | null>(null);
const [ebikeCoolingInstalled, setEbikeCoolingInstalled] = useState(false);
const reassemblyDoneTimeoutRef = useRef<number | null>(null); const reassemblyDoneTimeoutRef = useRef<number | null>(null);
// Ebike-specific: once the repair starts, keep the entire repair flow // Ebike-specific: once the repair starts, keep the entire repair flow
// exactly where the bike currently is. `Ebike` owns the live parked // exactly where the bike currently is. `Ebike` owns the live parked
@@ -115,11 +123,13 @@ export function RepairGame({
const livePosition = useMemo<Vector3Tuple>(() => { const livePosition = useMemo<Vector3Tuple>(() => {
if (mission !== "ebike" || step === "waiting") return position; if (mission !== "ebike" || step === "waiting") return position;
if (ebikeRepairTransform) return ebikeRepairTransform.position;
const parked = window.ebikeParkedPosition; const parked = window.ebikeParkedPosition;
if (!parked) return position; if (!parked) return position;
return [parked[0], parked[1], parked[2]]; return [parked[0], parked[1], parked[2]];
}, [mission, position, step]); }, [ebikeRepairTransform, mission, position, step]);
const usesLiveEbikePosition = mission === "ebike" && step !== "waiting"; const usesLiveEbikePosition = mission === "ebike" && step !== "waiting";
const parsedScale = toVector3Scale(scale); const parsedScale = toVector3Scale(scale);
const terrainSnappedPosition = useTerrainSnappedPosition(livePosition); const terrainSnappedPosition = useTerrainSnappedPosition(livePosition);
@@ -133,6 +143,10 @@ export function RepairGame({
); );
const isSplitPhase = (SPLIT_PHASES as readonly MissionStep[]).includes(step); const isSplitPhase = (SPLIT_PHASES as readonly MissionStep[]).includes(step);
const isRepairing = step === "repairing"; const isRepairing = step === "repairing";
const repairModelRotation: Vector3Tuple =
mission === "ebike" && ebikeRepairTransform
? [0, ebikeRepairTransform.rotationY, 0]
: (config.modelRotation ?? [0, 0, 0]);
const ebikeBrokenNodeName = config.brokenParts[0]?.targetNodeName; const ebikeBrokenNodeName = config.brokenParts[0]?.targetNodeName;
const ebikeBrokenWorldAnchor = ebikeBrokenNodeName const ebikeBrokenWorldAnchor = ebikeBrokenNodeName
? brokenAnchors[ebikeBrokenNodeName] ? brokenAnchors[ebikeBrokenNodeName]
@@ -159,6 +173,7 @@ export function RepairGame({
setCaseAnchors({}); setCaseAnchors({});
setBrokenAnchors({}); setBrokenAnchors({});
setScannedBrokenParts([]); setScannedBrokenParts([]);
setEbikeCoolingInstalled(false);
}, 0); }, 0);
return () => { return () => {
@@ -166,6 +181,45 @@ export function RepairGame({
}; };
}, [mainState, mission, step]); }, [mainState, mission, step]);
useEffect(() => {
if (mission !== "ebike") return undefined;
if (mainState !== "ebike" || step === "waiting") {
const timeoutId = window.setTimeout(() => {
setEbikeRepairTransform(null);
setEbikeCoolingInstalled(false);
}, 0);
return () => {
window.clearTimeout(timeoutId);
};
}
if (ebikeRepairTransform) return undefined;
const parked = window.ebikeParkedPosition;
const rotationY =
window.ebikeParkedRotation ?? config.modelRotation?.[1] ?? 0;
const snapshot: EbikeRepairTransform = {
position: parked ? [parked[0], parked[1], parked[2]] : position,
rotationY,
};
const timeoutId = window.setTimeout(() => {
setEbikeRepairTransform(snapshot);
}, 0);
return () => {
window.clearTimeout(timeoutId);
};
}, [
config.modelRotation,
ebikeRepairTransform,
mainState,
mission,
position,
step,
]);
useEffect(() => { useEffect(() => {
if (mission !== "ebike") return; if (mission !== "ebike") return;
if (mainState === "ebike") return; if (mainState === "ebike") return;
@@ -350,6 +404,14 @@ export function RepairGame({
}; };
}, []); }, []);
function handleEbikeCoolingInstall(): void {
if (ebikeCoolingInstalled) return;
setEbikeCoolingInstalled(true);
window.setTimeout(() => {
setMissionStep(mission, "reassembling");
}, 450);
}
if (mainState !== mission) return null; if (mainState !== mission) return null;
if (step === "locked") return null; if (step === "locked") return null;
@@ -376,7 +438,7 @@ export function RepairGame({
{isRepairPhase ? ( {isRepairPhase ? (
<ExplodableModel <ExplodableModel
modelPath={config.modelPath} modelPath={config.modelPath}
rotation={config.modelRotation ?? [0, 0, 0]} rotation={repairModelRotation}
scale={config.modelScale ?? 1} scale={config.modelScale ?? 1}
split={isSplitPhase} split={isSplitPhase}
splitSpeed={REPAIR_FRAGMENT_SPLIT_SPEED} splitSpeed={REPAIR_FRAGMENT_SPLIT_SPEED}
@@ -405,7 +467,7 @@ export function RepairGame({
{step === "repairing" && mission === "ebike" ? ( {step === "repairing" && mission === "ebike" ? (
<RepairEbikeRepairTrigger <RepairEbikeRepairTrigger
anchor={ebikeBrokenLocalAnchor} anchor={ebikeBrokenLocalAnchor}
onRepair={() => setMissionStep(mission, "reassembling")} installed={ebikeCoolingInstalled}
/> />
) : null} ) : null}
{step === "repairing" && mission !== "ebike" ? ( {step === "repairing" && mission !== "ebike" ? (
@@ -441,8 +503,13 @@ export function RepairGame({
showFragmentationPrompt={ showFragmentationPrompt={
readyForFragmentation && mission !== "ebike" readyForFragmentation && mission !== "ebike"
} }
{...(mission === "ebike" && step === "repairing"
? { interactLabel: "Changez le refroidisseur" }
: {})}
onInteract={ onInteract={
readyForFragmentation && mission !== "ebike" mission === "ebike" && step === "repairing"
? handleEbikeCoolingInstall
: readyForFragmentation && mission !== "ebike"
? () => setMissionStep(mission, "fragmented") ? () => setMissionStep(mission, "fragmented")
: undefined : undefined
} }
@@ -25,6 +25,7 @@ interface RepairMissionCaseProps {
open?: boolean; open?: boolean;
zoomed?: boolean; zoomed?: boolean;
showFragmentationPrompt?: boolean; showFragmentationPrompt?: boolean;
interactLabel?: string;
onInteract?: (() => void) | undefined; onInteract?: (() => void) | undefined;
} }
@@ -37,6 +38,7 @@ export function RepairMissionCase({
open = false, open = false,
zoomed = false, zoomed = false,
showFragmentationPrompt = false, showFragmentationPrompt = false,
interactLabel,
onInteract, onInteract,
}: RepairMissionCaseProps): React.JSX.Element { }: RepairMissionCaseProps): React.JSX.Element {
const casePosition = zoomed const casePosition = zoomed
@@ -51,7 +53,7 @@ export function RepairMissionCase({
<TriggerObject <TriggerObject
position={casePosition} position={casePosition}
colliders="ball" colliders="ball"
label={`Ouvrir ${config.label}`} label={interactLabel ?? `Ouvrir ${config.label}`}
radius={REPAIR_INTERACTION_RADIUS} radius={REPAIR_INTERACTION_RADIUS}
onTrigger={onInteract} onTrigger={onInteract}
> >
@@ -1,4 +1,4 @@
import { useEffect, useRef } from "react"; import { useEffect, useRef, useState } from "react";
import { useFrame, useThree } from "@react-three/fiber"; import { useFrame, useThree } from "@react-three/fiber";
import { RigidBody } from "@react-three/rapier"; import { RigidBody } from "@react-three/rapier";
import type { RapierRigidBody } from "@react-three/rapier"; import type { RapierRigidBody } from "@react-three/rapier";
@@ -35,6 +35,7 @@ interface GrabbableObjectProps {
label?: string; label?: string;
handControlled?: boolean; handControlled?: boolean;
disabled?: boolean; disabled?: boolean;
lockUntilGrab?: boolean;
onGrabChange?: (held: boolean) => void; onGrabChange?: (held: boolean) => void;
onPositionChange?: (position: THREE.Vector3) => void; onPositionChange?: (position: THREE.Vector3) => void;
onSnap?: (position: THREE.Vector3) => void; onSnap?: (position: THREE.Vector3) => void;
@@ -134,6 +135,7 @@ export function GrabbableObject({
label = GRAB_DEFAULT_LABEL, label = GRAB_DEFAULT_LABEL,
handControlled = false, handControlled = false,
disabled = false, disabled = false,
lockUntilGrab = false,
onGrabChange, onGrabChange,
onPositionChange, onPositionChange,
onSnap, onSnap,
@@ -148,6 +150,7 @@ export function GrabbableObject({
const rbRef = useRef<RapierRigidBody>(null); const rbRef = useRef<RapierRigidBody>(null);
const isHolding = useRef(false); const isHolding = useRef(false);
const isHandHolding = useRef(false); const isHandHolding = useRef(false);
const [hasBeenGrabbed, setHasBeenGrabbed] = useState(false);
const snapTween = useRef<gsap.core.Tween | null>(null); const snapTween = useRef<gsap.core.Tween | null>(null);
useEffect(() => { useEffect(() => {
@@ -288,6 +291,7 @@ export function GrabbableObject({
const hadHit = Boolean(hit); const hadHit = Boolean(hit);
if (hadHit) { if (hadHit) {
setHasBeenGrabbed(true);
isHandHolding.current = true; isHandHolding.current = true;
InteractionManager.getInstance().setHandHolding(true); InteractionManager.getInstance().setHandHolding(true);
onGrabChange?.(true); onGrabChange?.(true);
@@ -330,7 +334,7 @@ export function GrabbableObject({
<group ref={spaceRef}> <group ref={spaceRef}>
<RigidBody <RigidBody
ref={rbRef} ref={rbRef}
type="dynamic" type={lockUntilGrab && !hasBeenGrabbed ? "fixed" : "dynamic"}
colliders={colliders} colliders={colliders}
position={position} position={position}
> >
@@ -344,6 +348,7 @@ export function GrabbableObject({
position={position} position={position}
bodyRef={rbRef} bodyRef={rbRef}
onPress={() => { onPress={() => {
setHasBeenGrabbed(true);
isHolding.current = true; isHolding.current = true;
onGrabChange?.(true); onGrabChange?.(true);
}} }}