chore: address code quality audit findings

src/managers/stores/useGameStore.ts

@@ -1,5 +1,10 @@
 import { create } from "zustand";
-import { GAME_STEPS, type GameStep } from "@/types/game";
+import {
+  isGameStep,
+  isMainGameState,
+  type GameStep,
+  type MainGameState,
+} from "@/types/game";
 import {
   isRepairMissionId,
   isMissionStep,
@@ -15,7 +20,6 @@ import {
 } from "@/utils/debug/debugGameStateCookie";
 import { isDebugEnabled } from "@/utils/debug/isDebugEnabled";
 
-export type MainGameState = "intro" | "bike" | "pylone" | "ferme" | "outro";
 export type { MissionStep, RepairMissionId };
 
 interface IntroState {
@@ -86,14 +90,6 @@ interface GameActions {
 type GameStore = GameState & GameActions;
 type GameStateUpdate = Partial<GameState>;
 
-const MAIN_GAME_STATES: readonly MainGameState[] = [
-  "intro",
-  "bike",
-  "pylone",
-  "ferme",
-  "outro",
-];
-
 function isRecord(value: unknown): value is Record<string, unknown> {
   return typeof value === "object" && value !== null;
 }
@@ -106,14 +102,6 @@ function isBoolean(value: unknown): value is boolean {
   return typeof value === "boolean";
 }
 
-function isMainGameState(value: unknown): value is MainGameState {
-  return MAIN_GAME_STATES.includes(value as MainGameState);
-}
-
-function isGameStep(value: unknown): value is GameStep {
-  return GAME_STEPS.includes(value as GameStep);
-}
-
 function completeIntroState(state: GameState): GameStateUpdate {
   return {
     mainState: "bike",

src/managers/stores/useMapPerformanceStore.ts

@@ -26,6 +26,10 @@ export type MapPerformanceModelName =
   | "pylone"
   | "boiteauxlettres"
   | "maison1"
+  | "panneauaffichage"
+  | "panneauclassique"
+  | "panneaufleche"
+  | "panneausolaire"
   | "parcebike"
   | "terrain"
   | "sky";
@@ -70,6 +74,10 @@ export const MAP_PERFORMANCE_MODEL_NAMES: readonly MapPerformanceModelName[] = [
   "pylone",
   "boiteauxlettres",
   "maison1",
+  "panneauaffichage",
+  "panneauclassique",
+  "panneaufleche",
+  "panneausolaire",
   "parcebike",
   "terrain",
   "sky",
@@ -94,6 +102,10 @@ const MODEL_GROUPS: Record<
   pylone: ["props"],
   boiteauxlettres: ["props"],
   maison1: ["buildings"],
+  panneauaffichage: ["props"],
+  panneauclassique: ["props"],
+  panneaufleche: ["props"],
+  panneausolaire: ["props"],
   parcebike: ["props"],
   terrain: ["terrain"],
   sky: ["sky"],
@@ -115,10 +127,10 @@ function createDefaultVisibility(): MapPerformanceVisibility {
   };
 }
 
-export function isMapPerformanceModelName(
+function isMapPerformanceModelName(
   name: string,
 ): name is MapPerformanceModelName {
-  return MAP_PERFORMANCE_MODEL_NAMES.includes(name as MapPerformanceModelName);
+  return (MAP_PERFORMANCE_MODEL_NAMES as readonly string[]).includes(name);
 }
 
 export function isMapModelVisible(

src/managers/stores/useSettingsStore.ts

@@ -1,9 +1,7 @@
 import { create } from "zustand";
 import { AudioManager } from "@/managers/AudioManager";
 import type { AudioCategory } from "@/managers/AudioManager";
-
-export type SubtitleLanguage = "fr" | "en";
-export type RepairRuntime = "js" | "python";
+import type { SubtitleLanguage } from "@/types/settings/settings";
 
 interface SettingsState {
   isSettingsMenuOpen: boolean;
@@ -12,7 +10,6 @@ interface SettingsState {
   dialogueVolume: number;
   subtitlesEnabled: boolean;
   subtitleLanguage: SubtitleLanguage;
-  repairRuntime: RepairRuntime;
 }
 
 interface SettingsActions {
@@ -22,7 +19,6 @@ interface SettingsActions {
   setDialogueVolume: (volume: number) => void;
   setSubtitlesEnabled: (enabled: boolean) => void;
   setSubtitleLanguage: (language: SubtitleLanguage) => void;
-  setRepairRuntime: (runtime: RepairRuntime) => void;
   resetSettings: () => void;
 }
 
@@ -35,7 +31,6 @@ const DEFAULT_SETTINGS: SettingsState = {
   dialogueVolume: 1,
   subtitlesEnabled: true,
   subtitleLanguage: "fr",
-  repairRuntime: "js",
 };
 
 function clampVolume(volume: number): number {
@@ -79,7 +74,6 @@ export const useSettingsStore = create<SettingsStore>()((set) => ({
     set({ dialogueVolume: setAudioCategoryVolume("dialogue", volume) }),
   setSubtitlesEnabled: (subtitlesEnabled) => set({ subtitlesEnabled }),
   setSubtitleLanguage: (subtitleLanguage) => set({ subtitleLanguage }),
-  setRepairRuntime: (repairRuntime) => set({ repairRuntime }),
   resetSettings: () => {
     applyDefaultAudioSettings();
     set(DEFAULT_SETTINGS);