chore: address code quality audit findings

src/utils/dialogues/playDialogue.ts

@@ -2,10 +2,8 @@ import { AudioManager } from "@/managers/AudioManager";
 import { useSettingsStore } from "@/managers/stores/useSettingsStore";
 import { useSubtitleStore } from "@/managers/stores/useSubtitleStore";
 import type { DialogueManifest } from "@/types/dialogues/dialogues";
-import {
-  loadDialogueManifest,
-  loadDialogueSubtitleCue,
-} from "@/utils/dialogues/loadDialogueManifest";
+import { logger } from "@/utils/core/Logger";
+import { loadDialogueSubtitleCue } from "@/utils/dialogues/loadDialogueManifest";
 
 interface QueuedDialogueRequest {
   manifest: DialogueManifest;
@@ -15,8 +13,6 @@ interface QueuedDialogueRequest {
 
 const DIALOGUE_PLAY_START_TIMEOUT_MS = 800;
 const dialogueQueue: QueuedDialogueRequest[] = [];
-let gameplayDialogueManifestPromise: Promise<DialogueManifest | null> | null =
-  null;
 let isDialogueQueuePlaying = false;
 
 export function queueDialogueById(
@@ -35,16 +31,6 @@ export function clearQueuedDialogues(): void {
   }
 }
 
-export async function playGameplayDialogueById(
-  dialogueId: string,
-): Promise<HTMLAudioElement | null> {
-  gameplayDialogueManifestPromise ??= loadDialogueManifest();
-  const manifest = await gameplayDialogueManifestPromise;
-  if (!manifest) return null;
-
-  return queueDialogueById(manifest, dialogueId);
-}
-
 export async function playDialogueById(
   manifest: DialogueManifest,
   dialogueId: string,
@@ -117,7 +103,11 @@ async function playNextQueuedDialogue(): Promise<void> {
       );
       request.resolve(audio);
       if (audio) await waitForDialogueToFinish(audio);
-    } catch {
+    } catch (error) {
+      logger.error("Dialogues", "Failed to play queued dialogue", {
+        dialogueId: request.dialogueId,
+        error: error instanceof Error ? error : String(error),
+      });
       request.resolve(null);
     }
   }