chore: address code quality audit findings

src/world/map-instancing/MapInstancingSystem.tsx

@@ -1,8 +1,8 @@
-import { Suspense, useCallback, useMemo, useRef, useState } from "react";
-import { useFrame, useThree } from "@react-three/fiber";
-import { CHUNK_CONFIG } from "@/data/world/fogConfig";
+import { Suspense, useMemo } from "react";
+import { CHUNK_CONFIG } from "@/data/world/chunkStreamingConfig";
 import { useCameraMode } from "@/hooks/debug/useCameraMode";
 import { useSceneMode } from "@/hooks/debug/useSceneMode";
+import { useVisibleWorldChunks } from "@/hooks/world/useVisibleWorldChunks";
 import {
   isMapModelVisible,
   useMapPerformanceStore,
@@ -10,13 +10,14 @@ import {
 import { InstancedMapAsset } from "@/world/map-instancing/InstancedMapAsset";
 import {
   MAP_INSTANCING_ASSETS,
+  MAP_INSTANCING_ASSET_TYPES,
   type MapInstancingAssetConfig,
   type MapInstancingAssetType,
-} from "@/world/map-instancing/mapInstancingConfig";
+} from "@/data/world/mapInstancingConfig";
 import {
   type MapAssetInstance,
   useMapInstancingData,
-} from "@/world/map-instancing/useMapInstancingData";
+} from "@/hooks/world/useMapInstancingData";
 
 interface MapAssetChunk {
   key: string;
@@ -72,23 +73,20 @@ function createMapAssetChunks(
 }
 
 export function MapInstancingSystem(): React.JSX.Element | null {
-  const camera = useThree((state) => state.camera);
   const cameraMode = useCameraMode();
   const sceneMode = useSceneMode();
   const groups = useMapPerformanceStore((state) => state.groups);
   const models = useMapPerformanceStore((state) => state.models);
   const { data, isLoading } = useMapInstancingData();
-  const lastUpdateRef = useRef(-CHUNK_CONFIG.updateInterval);
-  const [activeChunkKeys, setActiveChunkKeys] = useState<Set<string>>(
-    () => new Set(),
-  );
   const streamingEnabled =
     CHUNK_CONFIG.enabled && sceneMode === "game" && cameraMode === "player";
 
   const chunks = useMemo(() => {
     if (!data) return [];
 
-    return Object.entries(MAP_INSTANCING_ASSETS).flatMap(([type, config]) => {
+    return MAP_INSTANCING_ASSET_TYPES.flatMap((type) => {
+      const config = MAP_INSTANCING_ASSETS[type];
+
       if (
         !config.enabled ||
         !isMapModelVisible(config.mapName, { groups, models })
@@ -96,71 +94,14 @@ export function MapInstancingSystem(): React.JSX.Element | null {
         return [];
       }
 
-      const instances = data.get(type as MapInstancingAssetType);
+      const instances = data.get(type);
       if (!instances || instances.length === 0) return [];
 
-      return createMapAssetChunks(
-        type as MapInstancingAssetType,
-        config,
-        instances,
-      );
+      return createMapAssetChunks(type, config, instances);
     });
   }, [data, groups, models]);
 
-  const visibleChunks = streamingEnabled
-    ? chunks.filter((chunk) => {
-        if (activeChunkKeys.size > 0) {
-          return activeChunkKeys.has(chunk.key);
-        }
-
-        return (
-          Math.hypot(
-            chunk.centerX - camera.position.x,
-            chunk.centerZ - camera.position.z,
-          ) <= CHUNK_CONFIG.loadRadius
-        );
-      })
-    : chunks;
-
-  const updateActiveChunks = useCallback(() => {
-    const nextKeys = new Set<string>();
-    const cameraX = camera.position.x;
-    const cameraZ = camera.position.z;
-
-    for (const chunk of chunks) {
-      const distance = Math.hypot(
-        chunk.centerX - cameraX,
-        chunk.centerZ - cameraZ,
-      );
-      const wasActive = activeChunkKeys.has(chunk.key);
-      const radius = wasActive
-        ? CHUNK_CONFIG.unloadRadius
-        : CHUNK_CONFIG.loadRadius;
-
-      if (distance <= radius) {
-        nextKeys.add(chunk.key);
-      }
-    }
-
-    if (
-      nextKeys.size === activeChunkKeys.size &&
-      [...nextKeys].every((key) => activeChunkKeys.has(key))
-    ) {
-      return;
-    }
-
-    setActiveChunkKeys(nextKeys);
-  }, [activeChunkKeys, camera, chunks]);
-
-  useFrame(({ clock }) => {
-    if (!streamingEnabled) return;
-
-    const now = clock.elapsedTime * 1000;
-    if (now - lastUpdateRef.current < CHUNK_CONFIG.updateInterval) return;
-    lastUpdateRef.current = now;
-
-    updateActiveChunks();
-  });
+  const visibleChunks = useVisibleWorldChunks(chunks, streamingEnabled);
 
   if (isLoading || !data) {
     return null;