fix: harden upload resilience and contracts
This commit is contained in:
@@ -8,7 +8,12 @@ import {
|
||||
findNextVersion,
|
||||
} from '@/lib/nextcloud'
|
||||
import { acquireUploadLock, releaseUploadLock } from '@/lib/upload-lock'
|
||||
import { parseDriveRequestBody } from '@/lib/upload-request'
|
||||
import {
|
||||
readDriveRequestBody,
|
||||
uploadErrorMessageResponse,
|
||||
uploadErrorResponse,
|
||||
uploadLockConflictResponse,
|
||||
} from '@/lib/upload-request'
|
||||
import { getErrorMessage } from '@/lib/guards'
|
||||
import type { DriveAction } from '@/lib/types'
|
||||
|
||||
@@ -20,9 +25,9 @@ export async function POST(req: NextRequest) {
|
||||
if (authError) return authError
|
||||
|
||||
if (!process.env.NEXTCLOUD_URL || !process.env.NEXTCLOUD_SHARE_TOKEN) {
|
||||
return NextResponse.json(
|
||||
{ success: false, error: 'Nextcloud non configure sur le serveur (NEXTCLOUD_URL, NEXTCLOUD_SHARE_TOKEN)' },
|
||||
{ status: 500 },
|
||||
return uploadErrorMessageResponse(
|
||||
'Nextcloud non configure sur le serveur (NEXTCLOUD_URL, NEXTCLOUD_SHARE_TOKEN)',
|
||||
500,
|
||||
)
|
||||
}
|
||||
|
||||
@@ -31,23 +36,18 @@ export async function POST(req: NextRequest) {
|
||||
let action: DriveAction
|
||||
|
||||
try {
|
||||
const body: unknown = await req.json()
|
||||
const parsedBody = parseDriveRequestBody(body)
|
||||
const parsedBody = await readDriveRequestBody(req)
|
||||
action = parsedBody.action
|
||||
const stagingId = parsedBody.stagingId
|
||||
const staged = await readStagedOriginalFiles(stagingId)
|
||||
folderName = staged.folderName
|
||||
parsedFiles = staged.files
|
||||
} catch (err) {
|
||||
const message = getErrorMessage(err)
|
||||
return NextResponse.json({ success: false, error: message }, { status: 400 })
|
||||
return uploadErrorResponse(err, 400)
|
||||
}
|
||||
|
||||
if (!acquireUploadLock(folderName)) {
|
||||
return NextResponse.json(
|
||||
{ success: false, error: 'Un upload est deja en cours pour ce dossier. Patientez quelques secondes.' },
|
||||
{ status: 409 },
|
||||
)
|
||||
return uploadLockConflictResponse()
|
||||
}
|
||||
|
||||
const basePath = process.env.NEXTCLOUD_BASE_PATH || 'Models'
|
||||
@@ -79,10 +79,7 @@ export async function POST(req: NextRequest) {
|
||||
})
|
||||
} catch (err) {
|
||||
const message = getErrorMessage(err, 'Erreur Nextcloud inconnue')
|
||||
return NextResponse.json(
|
||||
{ success: false, error: `Drive echoue: ${message}` },
|
||||
{ status: 500 },
|
||||
)
|
||||
return uploadErrorMessageResponse(`Drive echoue: ${message}`, 500)
|
||||
} finally {
|
||||
releaseUploadLock(folderName)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user